Skip to content

Conversation

@Tarkiin
Copy link

@Tarkiin Tarkiin commented Jul 31, 2025

Image_1 Image_2

@welcome
Copy link

welcome bot commented Jul 31, 2025

Thank you for submitting this pull request! We’ll get back to you as soon as we can!

@StevenBlack
Copy link
Owner

Wow, thank you for this @Tarkiin! Very nice work!

Please forgive me if I take some time to review and consider this PR. Please don't be offended if this takes time.

I love what I see so far 🙂

@StevenBlack
Copy link
Owner

@Tarkiin this new feature should be mentioned in the readme_template.md file file so folks know this exists.

I think this would belong as a new Option 4 under Generate your own unified hosts file in the readme_template.

How's your English?

@Tarkiin
Copy link
Author

Tarkiin commented Aug 1, 2025

@StevenBlack
I've updated the readme_template.md as requested. The GUI application is now documented as Option 4 under the "Generate your own unified hosts file" section.

I'm currently learning programming and how to contribute to open-source projects, so I really appreciate the opportunity to contribute and improve my skills through this PR.

Thank you for your guidance!

I’m just learning to use Git and GitHub, so I might still not do it correctly — PRs, commits, etc.
My written English is intermediate/low.

@funilrys
Copy link
Contributor

funilrys commented Aug 2, 2025

Hey @Tarkiin,

welcome & good job so far.

Please do not forget to apply black against your main.py.

Could you also use English everywhere (including main.py) and maybe add a dedicated language file for your primary language?

@StevenBlack
Copy link
Owner

Thank you for the assist Nissar @funilrys!

@Tarkiin you're doing great, no worries!

Here's a consideration @Tarkiin: OSS maintainers are always thankful for meaningful and substantial contributions. BUT this often cuts both ways. Here's why.

On one hand we have a very nice contribution. But on the other hand the contribution saddles the project with the long-term maintenance of that contribution, and of its extension.

For example, this PR has a language file. This is good! Except this is not without long-term maintenance cost. I see two long-term maintenance factors with this: first, there's potentially an explosion of languages to support. Second, each additional language adds significant inertia, so even minor UI changes probably mean potentially several language translations to complete any new implementation. And depending on how this is structured, after language translation there may be documentation screen shots to update for each language. This isn't the case right now, but this is an example of how simple things can cause future pain in unintended ways. All these long-term considerations merit some thought.

So, it's complicated 🙂 and, as someone who is new, it's good that you're aware of things such as these as your career evolves.

import requests
import webview
import threading
import time

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'time' is not used.
import concurrent.futures
from pathlib import Path
from datetime import datetime
from urllib.parse import urlparse

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'urlparse' is not used.
@XhmikosR
Copy link
Contributor

IMHO this should be a separate repo and just linked from the README of this repo if @StevenBlack considers it so. It doesn't make sense from a maintenance perspective to have the code here, in the upstream project.

Just my 2 cents :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants