Add AstroSat-LAXPC specific codes #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a quick fix being implemented at the moment. LAXPC's current software results in a column heading called "LAXPC_No." The current implementation of stingray converts this to an attribute named laxpc_no., which leads to an error in the compilation. For testing purposes, the original event file was modified to have a different name for the column but this needs to be changed in the stingray software.
Changes in the events.py Removed the functions specific to LAXPC and modified a filtering function to work on detector_id attribute instead. Changes in missions.py If the mission is AstroSat then the detector ID columns maps to LAXPC_No. Changes in io.py If the code detected a "." in the attribute name, it is replace with an underscore.
matteobachetti
requested changes
Jul 7, 2025
There was a problem hiding this comment.
Thanks @yashbhargava1992!
A few change requests, but it's overall good.
Don't forget the changelog entry!
Changes to events.py Now the filtering also accepts a list of detector ids. Changes to testio.py The code should ideally catch the warning due to lack of GTI extension in the event file. Added Changelog entry.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #929 +/- ##
===========================================
- Coverage 96.03% 79.66% -16.38%
===========================================
Files 48 48
Lines 9770 9787 +17
===========================================
- Hits 9383 7797 -1586
- Misses 387 1990 +1603 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@yashbhargava1992 strange that it looks for the PI column. I'll take a look tomorrow |
Changes to test_io.py Added a check to see is the instrument is LAXPC3 Changes to test_events.py Added a test to read the LAXPC file. This also catches warnings present while reading the LAXPC files. Changes to missions.py Manual assignment of the Energy/PI column and Instrument keyword from the header of the event file.
|
@yashbhargava1992 the missing coverage is from the two new methods in EventList, that I don't know if you want to keep. If so, they need to be tested ;) |
… and verify the length. The event file is also updated as it was an incorrect file.
matteobachetti
requested changes
Jul 10, 2025
Co-authored-by: Matteo Bachetti <[email protected]>
matteobachetti
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Inclusion of AstroSat/LAXPC in stingray IO
This PR is to include relevant codes that will allow testing and usage of LAXPC event files for analysis using Stingray.
Overview of the implemented solution and modifications.
Due to particular naming conventions implemented in LAXPC event files, certain functions and attributes have been modified.
LAXPC observations typically have 3 detector units and a particular use may want to select data from only 1 of them. Therefore the column which includes the information of the detector units (i.e. "LAXPC_No.") is mapped to
detector_idattribute.Additional functions to filter based on
detector_idare also included. Current implementation allows for filtering on a singledetector_id.A sample event file is included in the
stingray/tests/datadirectory and a test function is also included to check if file is loaded correctly.Future directions
The filtering based on multiple detectors can be included. This can allow for selection of events from a range of detectors from NICER or two detectors from LAXPC, for example.
Current implementation assumes that event file from AstroSat mission pertains to LAXPC (there are multiple mission onboard AstroSat) and is generated from a particular software (
LAXPCsoftware). These are not checked by the code and may result in file reading errors.