Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let users combine their balance #15

Merged
merged 24 commits into from
Dec 24, 2024
Merged

Conversation

wheval
Copy link

@wheval wheval commented Nov 27, 2024

fixes #2

@wheval wheval marked this pull request as ready for review December 3, 2024 19:57
@machuwey
Copy link
Collaborator

machuwey commented Dec 6, 2024

Hi @wheval ,

  1. We intend to have a one slide control, which will divide the total balance between each specified token (if there is two choosen).
    Right now I see that there is two triggers on the slider and the behaviour is quite confusing. Please refer a to the specified design.
  2. If there is only one token choosen, we don't need to show the slider at all (aka. make it reactive)

image

@machuwey machuwey added the help wanted Extra attention is needed label Dec 6, 2024
@wheval
Copy link
Author

wheval commented Dec 6, 2024

Hello @machuwey . So what i understand is ; The total price should be divided among the selected tokens.
Also, should there be a max no of tokens a user can combine?

@machuwey
Copy link
Collaborator

machuwey commented Dec 6, 2024

Hello @machuwey . So what i understand is ; The total price should be divided among the selected tokens. Also, should there be a max no of tokens a user can combine?

Yes, that's right. Imagine that the user want to part of the order with a memecoin for any reason (so he would pay with ETH + Memecoin).

For now focus on support of two tokens, but if possible follow good principles and make it easy to support 3 tokens in the future.

@wheval
Copy link
Author

wheval commented Dec 6, 2024

Okay. Would work on that ASAP

@machuwey machuwey self-requested a review December 10, 2024 16:36
@machuwey machuwey added reviewing and removed help wanted Extra attention is needed labels Dec 10, 2024
@machuwey machuwey changed the base branch from main to dev December 14, 2024 19:37
@machuwey machuwey merged commit 66b5466 into StrapexLabs:dev Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Let costumers combine balances from any token to pay
2 participants