Feat/github-actions-release #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the node-ssh module, the minimum required version of Node is Node 12. Update pkg to the next version that supports Node 12 or higher. The newer pkg version does not support building x86 executables, so those were removed from the targets, keeping only x64 targets.
we were able to build for windows x86 using a windows runner instead of a linux one.
the new build command allows to override the default build args,
ex:
npm run build -- --targets=node12-win-x64this will only build for windows x64.added 2 workflows. one for building on PR, executables can be downloaded from the artifacts of the workflow and tested by testers and used by devops for testing new features on servers.
and the other workflow for building and releasing to github after each push/merge to master.
added a workflow for releasing to npm on release to github. (a new release is released to github when version number changes) it requires adding npm_token to the repo's env vars
a working implementation can be found on this repo