Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct file mover #511

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

NooNameR
Copy link
Contributor

Description

Change mover logic from triggering entire move operation and just move single torrent files + links.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have modified this PR to merge to the develop branch

@NooNameR NooNameR marked this pull request as draft March 26, 2024 10:04
time.sleep(10)
# Start mover
print("Starting Mover")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we have it bellow, per each category: files, links, dirs

Copy link
Collaborator

@bakerboy448 bakerboy448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are numerous random edits removing or changing unrelated pieces. Why?

it appears this is likely just regurgitating chatgpt code vomit

@NooNameR
Copy link
Contributor Author

likely just regurgitating chatgpt code vomit

I'm not sure what you mean, by unrelated changes. All changes are completely related. If you are inclining of missing "comment", it just got lost in different re-ordering as it introduced different approach in comparison to just calling mover. As well, I did bunch of tests to polish the behavior.

I like to hear constructive feedback instead of "randomly chatgpt generated one"

NooNameR and others added 2 commits March 26, 2024 12:19
for more information, see https://pre-commit.ci

Make cache mount required

Refactor

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Fix for directories

More fixes

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Move comment back

fix cache mount comment

remove cachemount check
@NooNameR
Copy link
Contributor Author

there is still and odd case: there is can be hardlink for the torrent falling into the date range, but torrent which is using it might not - so we won't stop it before moving. (can happen with cross-seed quite easily). But this behavior exists with current mover as well

@AN1MATEK
Copy link

Do you think we can add an argument --mover-old instead of relying in people to comment or uncomment that line of code? I was gonna make a PR myself with this small change, but I see that you started some more important work here. It happened to me that last time I updated this script, I completely forgot about that part and got some unexpected results.

@NooNameR
Copy link
Contributor Author

Do you think we can add an argument --mover-old instead of relying in people to comment or uncomment that line of code? I was gonna make a PR myself with this small change, but I see that you started some more important work here. It happened to me that last time I updated this script, I completely forgot about that part and got some unexpected results.

I'm still not sure we are gonna push this changes at all. still under some consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants