-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direct file mover #511
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
9c8ac66
to
0cef813
Compare
for more information, see https://pre-commit.ci
time.sleep(10) | ||
# Start mover | ||
print("Starting Mover") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we have it bellow, per each category: files, links, dirs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are numerous random edits removing or changing unrelated pieces. Why?
it appears this is likely just regurgitating chatgpt code vomit
I'm not sure what you mean, by unrelated changes. All changes are completely related. If you are inclining of missing "comment", it just got lost in different re-ordering as it introduced different approach in comparison to just calling mover. As well, I did bunch of tests to polish the behavior. I like to hear constructive feedback instead of "randomly chatgpt generated one" |
for more information, see https://pre-commit.ci Make cache mount required Refactor [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Fix for directories More fixes [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Move comment back fix cache mount comment remove cachemount check
there is still and odd case: there is can be hardlink for the torrent falling into the date range, but torrent which is using it might not - so we won't stop it before moving. (can happen with cross-seed quite easily). But this behavior exists with current mover as well |
Do you think we can add an argument |
I'm still not sure we are gonna push this changes at all. still under some consideration |
Description
Change mover logic from triggering entire move operation and just move single torrent files + links.
Type of change
Please delete options that are not relevant.
Checklist: