Skip to content

Update syntax test output parsing for v4181 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Apr 10, 2025
Merged

Update syntax test output parsing for v4181 #25

merged 36 commits into from
Apr 10, 2025

Conversation

michaelblyons
Copy link
Contributor

I'm eating the error line to avoid duplicating it.
Fixes #24

Please squash. The commits are embarrassing.

Michael Lyons added 30 commits February 11, 2025 15:44
Adjust error message parsing for new syntax tests
7262436 
Extremely naively.
See SublimeText#24
Temporarily enable action on push
e2d366a
Temporarily disable action on cron
03f59cc
Temporarily make the build unattainable
9e84e79
Add some debug messages
b4933e5
Temporarily disable most of the tests
2f9f9bd
Fix echo for new test output
869405c
Add some debug trash
524ec75
Use no-IFS line for echo
3ba2433
Explicitly drop IFS
c18e2db
Cleanup line formatting
4aadc85
Add more debug
b049d4b
Fix new line test
1fb127a
Trim error text
c49b3ca
Revert "Temporarily make the build unattainable"
8f3a725 
This reverts commit 9e84e79.
Consolidate if statements
ec7841a
Revert "Consolidate if statements"
7b74f3d 
This reverts commit ec7841a.
Move the IFS assignment carefully
e9c1df5
Move new format first
300e6b0
Read log type
c893650
Fixup read log type
8b21661
Fixup log echo
e3dc260
Test reading message twice
d68e37a 
with mismatched arg length
Merge both old and new formats
ca849e1
Use math expansion for version test
3a72bb1
Add debug statements
7d66cdf
Add another debug statement
5f22e57
Fix file path rewrite
e468f88
Revert "Temporarily disable most of the tests"
de2a370 
This reverts commit 2f9f9bd.
Remove debug statements
a3da7f2
@michaelblyons
Copy link
Contributor Author

I added an extra test in the intentional failures test to make sure that changing IFS wouldn't throw off test failures after the first one.

@michaelblyons michaelblyons changed the title Update syntax test output parsing for v4081 Update syntax test output parsing for v4181 Feb 17, 2025
@michaelblyons
Fix version number
ef9a3b4 
New update was 4181, not 4081
@FichteFoll FichteFoll changed the base branch from master to feature/4181-format April 10, 2025 18:11
FichteFoll
FichteFoll approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@FichteFoll FichteFoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I'll squash this to a working branch so that I can iterate a bit on it myself.

@FichteFoll FichteFoll added this to the v2.5 milestone Apr 10, 2025
@FichteFoll FichteFoll merged commit 6d9060a into SublimeText:feature/4181-format Apr 10, 2025
8 checks passed
@FichteFoll FichteFoll mentioned this pull request Apr 10, 2025
Merged
FichteFoll pushed a commit that referenced this pull request Apr 10, 2025
@michaelblyons @FichteFoll
Update syntax test output parsing for v4181 (#25)
e7fd991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FichteFoll FichteFoll FichteFoll approved these changes

@jrappen jrappen jrappen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5
Development

Successfully merging this pull request may close these issues.

Adjust error message parsing for the new syntax test output format
3 participants
@michaelblyons @FichteFoll @jrappen