chore: stop using substra-tools base images #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SdgJlbl
force-pushed
the
chore/frop-substratools-image
branch
2 times, most recently
from
e6e9fe3 to
c431e36
Compare
SdgJlbl
commented
Jul 12, 2024
SdgJlbl
force-pushed
the
chore/frop-substratools-image
branch
6 times, most recently
from
95e29a7 to
898bea9
Compare
thbcmlowk
reviewed
Jul 16, 2024
substratest/settings.py
Outdated
Comment on lines
16
to
17
| _DEFAULT_DOCKER_TAG_LOCAL = f"{sys.version_info.major}.{sys.version_info.minor}-slim" | ||
| _DEFAULT_DOCKER_TAG_REMOTE = "3.11-slim" |
There was a problem hiding this comment.
Why do we need these two versions, won't _DEFAULT_DOCKER_TAG_LOCAL return 3.11-slim if started from the correct Python version?
I can see that before, there was a difference in path (the former without ghcr.io, the later with), but it looks like to me that we could use this opportunity to simplify the code
SdgJlbl
force-pushed
the
chore/frop-substratools-image
branch
from
898bea9 to
9ba29bb
Compare
Signed-off-by: SdgJlbl <[email protected]>
SdgJlbl
force-pushed
the
chore/frop-substratools-image
branch
from
9ba29bb to
a6ab223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.