Skip to content

feat: add tests to check cleaning of transient output assets #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

guilhem-barthes
Copy link
Contributor

Fixes FL-1666

@guilhem-barthes guilhem-barthes requested a review from a team as a code owner July 16, 2024 14:26
Copy link

linear bot commented Jul 16, 2024

@guilhem-barthes guilhem-barthes marked this pull request as draft July 16, 2024 14:26
@guilhem-barthes
Copy link
Contributor Author

/e2e

@Owlfred
Copy link

Owlfred commented Jul 16, 2024

End to end tests: ❌ FAILURE

Jobs status:

I'm sorry.

@guilhem-barthes
Copy link
Contributor Author

/e2e --refs orchestrator=fix/panic-when-disable-output-without-assets

@Owlfred
Copy link

Owlfred commented Jul 16, 2024

End to end tests: ❌ FAILURE

Jobs status:

Not this time.

@guilhem-barthes guilhem-barthes force-pushed the feat/test-handling-transient-output-assets-after-build-error branch from aa14cc6 to bd8ba77 Compare July 17, 2024 08:43
@guilhem-barthes
Copy link
Contributor Author

/e2e --refs orchestrator=fix/panic-when-disable-output-without-assets

@Owlfred
Copy link

Owlfred commented Jul 17, 2024

End to end tests: ❌ FAILURE

Jobs status:

“Success is not final; failure is not fatal: It is the courage to continue that counts.” ―- Winston S. Churchill

@guilhem-barthes
Copy link
Contributor Author

/e2e --refs orchestrator=fix/panic-when-disable-output-without-assets --tests sdk,substrafl

@Owlfred
Copy link

Owlfred commented Jul 17, 2024

End to end tests: ❌ FAILURE

Jobs status:

Not this time.

@guilhem-barthes
Copy link
Contributor Author

/e2e --refs orchestrator=fix/panic-when-disable-output-without-assets --tests sdk,substrafl

@Owlfred
Copy link

Owlfred commented Jul 17, 2024

End to end tests: ❌ FAILURE

Jobs status:

Too bad.

@guilhem-barthes guilhem-barthes force-pushed the feat/test-handling-transient-output-assets-after-build-error branch from cbd710b to 6107839 Compare July 18, 2024 08:43
@guilhem-barthes
Copy link
Contributor Author

/e2e --refs orchestrator=fix/panic-when-disable-output-without-assets --tests sdk,substrafl

@Owlfred
Copy link

Owlfred commented Jul 18, 2024

End to end tests: ✔️ SUCCESS

@guilhem-barthes guilhem-barthes marked this pull request as ready for review July 18, 2024 09:28
@thbcmlowk
Copy link
Contributor

thbcmlowk commented Jul 19, 2024

/e2e --refs orchestrator=fix/panic-when-disable-output-without-assets --tests sdk,substrafl


Re-running the tests just to double check that time.sleep is consistently working. Otherwise, LGMT

@Owlfred
Copy link

Owlfred commented Jul 19, 2024

End to end tests: ✔️ SUCCESS

Copy link
Contributor

@thbcmlowk thbcmlowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🩹

@guilhem-barthes guilhem-barthes merged commit 0142ac0 into main Jul 19, 2024
5 checks passed
@guilhem-barthes guilhem-barthes deleted the feat/test-handling-transient-output-assets-after-build-error branch July 19, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants