-
Notifications
You must be signed in to change notification settings - Fork 183
fix: add affinity from events statefulset #3935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Eric Chlebek <[email protected]>
Signed-off-by: Eric Chlebek <[email protected]>
Signed-off-by: Eric Chlebek <[email protected]>
{{- if not (empty (include "otelcolInstrumentation.statefulset.affinity" .)) }} | ||
{{ include "otelcolInstrumentation.statefulset.affinity" . | indent 8 }} | ||
{{- if not (empty (include "events.statefulset.affinity" .)) }} | ||
{{ include "events.statefulset.affinity" . | indent 8 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth adding a template test for this - https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/tests/helm/README.md#helm-template-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, thanks for pointing me to that!
It appears that affinity from the instrumentation pod was included incorrectly.
Closes #3830