Azure observability install apps #256
Conversation
…ion-templates into azure_observability_install_apps
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 48 out of 51 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # ============================================================================ | ||
| azure_subscription_id = "your-azure-subscription-id" # Your Azure subscription ID | ||
| azure_client_id = "your-azure-client-id" # Service principal client ID | ||
| azure_client_secret = "your-azure-client-secret" # Service principal secret |
There was a problem hiding this comment.
How can these be found by the user, the subscription ID and Tenant ID are easy to find but client ID and client secret we need to create service principal in that the client secret is created. Should we mention that or a link of how to do so?
In the above section in Config variables we only have explained what it is and not how can we create it
|
|
||
| ## Troubleshooting | ||
|
|
||
| ### Azure Event Hub Regional Support |
There was a problem hiding this comment.
I think mentioning the number of eventhubs instances different tiers i.e basic, standard etc can handle should be added in this section. The user may face errors if using standard and more than 10 instances are being created and will visit this section to troubleshoot.
azure-collection-terraform/README.md
Outdated
| terraform destroy | ||
| ``` | ||
|
|
||
| **⚠️ Warning**: This will: |
There was a problem hiding this comment.
Can we move This will to next line ?? Same line has two colons :
|
|
||
| ### Azure Event Hub Regional Support | ||
|
|
||
| The table below shows Event Hub namespace availability across Azure regions by SKU tier. This module automatically handles region-specific SKU limitations. |
There was a problem hiding this comment.
| The table below shows Event Hub namespace availability across Azure regions by SKU tier. This module automatically handles region-specific SKU limitations. | |
| The tables below show Event Hub namespace availability across Azure regions by SKU tier. This module automatically handles region-specific SKU limitations. |
|
|
||
| - **Scope**. Activity logs capture ALL operations across the ENTIRE subscription (all resource groups, all resources). | ||
| - **Single Configuration**. Azure only allows **ONE** diagnostic setting for activity logs per subscription. | ||
| - **Shared Resource**. If multiple Terraform configurations or users enable activity logs on the same subscription, **only the last one applied will be active**. |
There was a problem hiding this comment.
| - **Shared Resource**. If multiple Terraform configurations or users enable activity logs on the same subscription, **only the last one applied will be active**. | |
| - **Shared Resource**: If multiple Terraform configurations or users enable activity logs on the same subscription, **only the last one applied will be active**. |
There was a problem hiding this comment.
Can we change for Scope, Single Configurations and Deletion Impact as well replace "." with ":"
No description provided.