add adjust linear amplification logic #86
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure we can define a sanity range for a, I assume it being a positive number is the least we should check, but is there an upper limit? |
validators/pool.ak
Outdated
| ) | ||
|
|
||
| // Make sure the linear amplification is in the sane range | ||
| expect linear_amplification > 0 && linear_amplification <= 10000 |
There was a problem hiding this comment.
the upper bound likely needs to be much higher, and i'm not sure we should even have an upper bound 🤔
There was a problem hiding this comment.
I agree, will remove that upper bound
There was a problem hiding this comment.
Let's just make sure to ask the auditors if they feel we should set an upper bound
| @@ -378,6 +378,7 @@ fn scoop(options: ScoopTestOptions) { | |||
| options.edit_initial_sum_invariant, | |||
| 2000000000000000000000, | |||
| ), | |||
| linear_amplification_manager: None, | |||
There was a problem hiding this comment.
we should add one test exercising this branch, ideally
There was a problem hiding this comment.
Using this as test bed for a property based test in the next PR, so will be covered by that.
|
Closing this to use #87 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature for managing the linear amplification factor in stable pools. The changes include adding a new field to the
StablePoolDatumtype.Feature Enhancements for Stable Pools:
linear_amplification_managerfield: TheStablePoolDatumtype now includes an optionallinear_amplification_managerfield, which represents a multisig condition for updating the linear amplification factor.ManageRedeemertype now includes anAdjustLinearAmplificationvariant to enable updates to the linear amplification factor.Updates to Asset Reserves and Validation:
pool_input_to_asset_reserves: Introduced a function to compute asset reserves while accounting for protocol fees and ADA-specific adjustments.