Slope collision algorithm rewrite #3140
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/supertux into slope-collision-rewrite
Member
|
Was GLM not being used in our OpenGL/video code at all?? :O |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok so I'm not the most math guy in here but I've come up with a simpler and better documented slope collision algorithm. Here, I plan to fix inconsistencies and weird edge cases that would otherwise be difficult to pinpoint with the old system.
Here I also removed all instances of glm::vec2 and replaced it with our own Vector class, which means that glm is ready to get removed.
Testers: Once I fully open this PR, please test all interactions with different types of slopes. And on a seemingly unrelated note, also test big snowball.