RCT-2097: Storybook scroll fix #132
Draft
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windok
force-pushed
the
yevhenii/RCT-2097-iframe-scroll
branch
2 times, most recently
from
5bbd93a
to
43d7960
Compare
windok
force-pushed
the
yevhenii/RCT-2097-iframe-scroll
branch
from
43d7960
to
6569534
Compare
honzatmn
approved these changes
May 13, 2024
| style="height: {{ (block.size && block.size.height && block.size.height < 150) ? block.size.height + "px" : "100%" }}" | ||
| ></iframe> | ||
| srcdoc=" | ||
| <iframe |
There was a problem hiding this comment.
This is a completely new pattern to me, so I'm not able to say if it's okay or not okay to have it like this.
How confident are you that it works for all what our Storybook block supports?
There was a problem hiding this comment.
Similar issue is present on FE for cloud. So, FE team will take a look on possible solutions as well and then we are going to make the same solution for doc exporter as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue happens because automatic scroll in iframe that controls parent window. Seems that iframe with storybook includes Element: scrollIntoView() invocation that can lead to issue.
To reproduce the issue I have found public Storybook example that scrolls content on document load: https://main--626696a2018c1f004a1cde86.chromatic.com/?path=/docs/components-collections-menu--docs.
There is open draft to W3C that aims to cover this behaviour but for now there is no browser agnostic solution.
I have used this fix for Chrome browsers that uses another Chrome bug, so it's not clear how long this fix will work until that second bug will be resolved.