Support _NET_WM_WINDOW_OPACITY
with alpha-modifier
#131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok this is admittedly very useless, especially as niri doesn't support it yet, although it's used by wine and supported by KDE. Not sure if it should be merged.
I mostly wanted to experiment with implementing a clientside only protocol, this is almost identical to xdg-decoration just a bit simpler because it doesn't have events it needs to handle.
Couple of things I noticed while implementing this:
set_win_opacity
is called,win.surface_key
isNone
so it doesn't actually set anything and it doesn't print anything, I'm pretty sure this applies to everything inhandle_window_attributes
. I removed it from the test for that reasonPropertyCookieWrapper
should be fallible, doesConnection::wait_for_reply
actually have any guarantee about the length of the reply (whenr#type != ATOM_NONE
)? Things like this can easily failServerState::set_*
methods doesn't feel great and forces more and more things intoSurfaceData
Also it should be double-buffered and tested as such in testwl, this is also currently missing for
min_size
andmax_size
Edit: I think this also needs to be added to the supported atom i3/i3#2840 (comment):