Recognize drag and drop window type #173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supreeeme
approved these changes
Jun 14, 2025
Comment on lines
+1745
to
+1750
| connection.set_property::<u32>( | ||
| discord_dnd, | ||
| x::ATOM_WM_SIZE_HINTS, | ||
| x::ATOM_WM_HINTS, | ||
| &[516, 20, 137, 0, 0, 0, 0, 0, 0], | ||
| ); |
|
I went ahead and fixed the test myself (ef24bce). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recognize
_NET_WM_WINDOW_TYPE_DNDused by discord as a popup, fixing #166.I tried to add an integration test for it, but found it was failing despite
guess_is_popup()returning true for the test window. Ultimately I gave up trying to get the test to work correctly in service of submitting something, and marked the test#[ignore].