Skip to content

Commit

Permalink
Merge pull request #26 from SvenGroot/net8
Browse files Browse the repository at this point in the history
Add testing for .Net 8.0
  • Loading branch information
SvenGroot authored Nov 14, 2023
2 parents 5292563 + a612201 commit 351ef12
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v3
with:
dotnet-version: 7.0.x
dotnet-version: 8.0.x
- name: Restore dependencies
run: dotnet restore src
- name: Build
Expand Down
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ The .Net 7.0 version has additional support for `required` properties, and can u

To build Ookii.CommandLine, make sure you have the following installed:

- [Microsoft .Net 7.0 SDK](https://dotnet.microsoft.com/download) or later
- [Microsoft .Net 8.0 SDK](https://dotnet.microsoft.com/download) or later
- [Microsoft PowerShell 6 or later](https://github.com/PowerShell/PowerShell)

PowerShell is used to generate some source files during the build. Besides installing it normally,
Expand All @@ -164,8 +164,9 @@ To build the library, tests and samples, simply use the `dotnet build` command i
directory. You can run the unit tests using `dotnet test`. The tests should pass on all platforms
(Windows and Linux have been tested).

The tests are built and run for .Net 7.0, .Net 6.0, and .Net Framework 4.8. Running the .Net
Framework tests on a non-Windows platform may require the use of [Mono](https://www.mono-project.com/).
The tests are built and run for .Net 8.0, .Net 7.0, .Net 6.0, and .Net Framework 4.8. Running the
.Net Framework tests on a non-Windows platform may require the use of
[Mono](https://www.mono-project.com/).

Ookii.CommandLine uses a strongly-typed resources file, which will not update correctly unless the
`Resources.resx` file is edited with [Microsoft Visual Studio](https://visualstudio.microsoft.com/).
Expand Down
2 changes: 1 addition & 1 deletion src/Ookii.CommandLine.Tests/Ookii.CommandLine.Tests.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net7.0;net6.0;net48</TargetFrameworks>
<TargetFrameworks>net8.0;net7.0;net6.0;net48</TargetFrameworks>
<Nullable>enable</Nullable>
<AssemblyTitle>Ookii.CommandLine Unit Tests</AssemblyTitle>
<Description>Tests for Ookii.CommandLine.</Description>
Expand Down
2 changes: 1 addition & 1 deletion src/Ookii.CommandLine/Ookii.CommandLine.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ library for .Net applications.
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="System.Collections.Immutable" Version="7.0.0" Condition="'$(TargetFramework)'=='netstandard2.0' Or '$(TargetFramework)'=='netstandard2.1'" />
<PackageReference Include="System.Collections.Immutable" Version="8.0.0" Condition="'$(TargetFramework)'=='netstandard2.0' Or '$(TargetFramework)'=='netstandard2.1'" />
<PackageReference Include="System.Memory" Version="4.5.5" Condition="'$(TargetFramework)'=='netstandard2.0'" />
</ItemGroup>

Expand Down

0 comments on commit 351ef12

Please sign in to comment.