Fix: Allow Alphanumeric and Underscore Characters in Socket.IO Event Names #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR modifies the regular expression used to extract Socket.IO event names to include alphanumeric characters and underscores by using \w.
Previously, the regex only matched lowercase alphabetic characters ([a-z]), which caused issues when event names contained underscores (e.g., "message_sent").
Using \w expands support to:
Changes Made:
Updated regex from:
r'(\d*)\["([a-z]*)"'
to
r'(\d*)\["(\w+)"'
Why This is Needed:
Our Socket.IO event names follow snake_case naming, which includes underscores. Without this change, events like "message_sent"" caused assertion failures during load testing with Locust.
Impact:
Prevents errors for valid Socket.IO events containing underscores or digits.
Improves compatibility and robustness of WebSocket load testing scripts.
Issue
Fixed this issue #220