This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Add XIB Parser and context provider #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
reviewed
May 23, 2017
Sources/Stencil/XIBContext.swift
Outdated
| } | ||
|
|
||
| return [ | ||
| "xibs": xibsMap, |
There was a problem hiding this comment.
this is the lint error, comments are off
This will allow SwiftGen to parse XIB files and therefore type-safe view controller creation based on XIB files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to add XIB parsers to add support on
SwiftGenfor parsing XIB files. This is particularly useful to add some compiler guarantees around View Controller creation.UIKitsupports creating view controllers from the same name as the xib file but since this happens on runtime, it'd be nice to support this fromswiftgen.I have a commit[0] ready for SwiftGen if this direction gets approved.
[0] Reflejo/SwiftGen@b4c45e0