Re enable collection signing #3788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finestructure
commented
May 2, 2025
| @@ -60,7 +61,7 @@ extension API { | |||
| } | |||
|
|
|||
|
|
|||
| extension PackageCollectionModel.V1.Collection: Vapor.Content {} | |||
| extension PackageCollectionSigning.Model.SignedCollection: @retroactive @unchecked Sendable, Vapor.Content {} | |||
There was a problem hiding this comment.
We should open a PR upstream to conform PackageCollectionModel.V1.Collection to Sendable so we can avoid this @retroactive @unchecked Sendable here.
finestructure
force-pushed
the
re-enable-collection-signing
branch
from
23f2cfd to
6fc3d3f
Compare
daveverwer
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3755