Use fdinfo's engine count when refreshing utilisation rate#387
Merged
Syllo merged 1 commit intoSyllo:masterfrom Jun 28, 2025
Merged
Use fdinfo's engine count when refreshing utilisation rate#387Syllo merged 1 commit intoSyllo:masterfrom
Syllo merged 1 commit intoSyllo:masterfrom
Conversation
I originally moved gpuinfo_refresh_utilisation_rate() from Mali code into src/extract_gpuinfo.c when I realised utilisation rate could be calculated in a device-independent way simply by following the percentage utilisation guidelines given in Documentation/gpu/drm-usage-stats.rst However, I forgot to replace the magic number '2' which stood for the engine count in Mali GPUs with a value that make sense for different devices. Source the engine count from gpu_info's static information values. Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
|
+1 |
Syllo
approved these changes
Jun 28, 2025
Owner
|
Thanks for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally moved gpuinfo_refresh_utilisation_rate() from Mali code into src/extract_gpuinfo.c when I realised utilisation rate could be calculated in a device-independent way simply by following the percentage utilisation guidelines given in
Documentation/gpu/drm-usage-stats.rst
However, I forgot to replace the magic number '2' which stood for the engine count in Mali GPUs with a value that make sense for different devices.
Source the engine count from gpu_info's static information values.