Unnecessary pass #475
Merged
Unnecessary pass #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcmitchell
reviewed
Mar 21, 2025
sbol3/property_base.py
Outdated
| @@ -55,7 +55,7 @@ def item_added(self, item: Any) -> None: | |||
| any additional processing on items after they are added. This method | |||
| will be called on each individual item that was added to the list. | |||
| """ | |||
| pass | |||
| pass # pylint: disable=unnecessary-pass | |||
There was a problem hiding this comment.
I assume there's a reason this pass can't be removed. Is that the case? If so, should an explanatory comment be added?
There was a problem hiding this comment.
Sorry, I forgot that we could remove the pass keyword from methods too, and it was just redundant here.
tcmitchell
requested changes
Mar 25, 2025
|
Done, thank you |
tcmitchell
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed pass statement, and disabled plint warning for stub method
item_addedin property_base.py#433