Skip to content

Conversation

@daniilrrr
Copy link
Collaborator

@daniilrrr daniilrrr commented Jul 14, 2025

Ticket

  • Related Linear Ticket: SEQ-1049

What does this PR do?

  • Summary:
    • CI go brr
  • Key Changes:
    • Correct docker buildx... command for our multi-target Dockerfile - no more for loop. 6x faster :)
    • Removed unused steps from the Dockerfile, including SP1 toolchain.
    • Small code change to /shared so that no part of the /synd-withdrawals directory nor the heavy ZK deps get pulled into other services. ZK deps like sp1 need to stay isolated to synd-withdrawals
    • test-framework module refactor to build fewer binaries. See below
  • <Goal of this section: someone reads this in a few months and at-a-glance understands why this change got made + what it is>

Breaking changes?

  • No

Metrics changes?

  • No

Anything interesting?

I discovered that cargo has special behavior for test files in a /tests directory. It will compile each test file into a separate binary. With many test files, that compilation overhead + all those artifacts add up. We can get around this via one main.rs test file which produces one binary for a faster+smaller build.
References:

How can this PR be tested?

  • CI

@linear
Copy link

linear bot commented Jul 14, 2025

SEQ-1049 Reduce build times for Docker images

use rust-cache (or similar) in our github actions to speed up our build times

also explore decoupling the withdrawals part

@daniilrrr daniilrrr force-pushed the daniil/SEQ-1049-docker-image-builds branch 2 times, most recently from 16028ca to 959b93d Compare July 15, 2025 23:20
@daniilrrr
Copy link
Collaborator Author

building just translator took me 12min locally with Orbstack.

docker build . --no-cache --target synd-translator

[+] Building 720.0s (14/14) FINISHED                                                                                                                      docker:orbstack

@daniilrrr daniilrrr force-pushed the daniil/SEQ-1049-docker-image-builds branch from 86119a5 to c226038 Compare July 16, 2025 16:24
@daniilrrr daniilrrr changed the title WIP - Daniil/seq 1049 docker image builds fix: improve Docker image publish speed Jul 16, 2025
@daniilrrr
Copy link
Collaborator Author

image image

@daniilrrr daniilrrr marked this pull request as ready for review July 16, 2025 17:07
Copy link
Collaborator

@jorgemmsilva jorgemmsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is crazy! great improvement!
⚡ ⚡ ⚡

@daniilrrr daniilrrr merged commit ebe21d6 into main Jul 16, 2025
6 checks passed
@daniilrrr daniilrrr deleted the daniil/SEQ-1049-docker-image-builds branch July 16, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants