-
Notifications
You must be signed in to change notification settings - Fork 0
fix: improve Docker image publish speed #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SEQ-1049 Reduce build times for Docker images
use rust-cache (or similar) in our github actions to speed up our build times also explore decoupling the withdrawals part |
16028ca to
959b93d
Compare
Collaborator
Author
|
building just |
86119a5 to
c226038
Compare
Collaborator
Author
jorgemmsilva
approved these changes
Jul 16, 2025
Collaborator
jorgemmsilva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is crazy! great improvement!
⚡ ⚡ ⚡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Ticket
What does this PR do?
docker buildx...command for our multi-target Dockerfile - no morefor loop. 6x faster :)/sharedso that no part of the/synd-withdrawalsdirectory nor the heavy ZK deps get pulled into other services. ZK deps likesp1need to stay isolated tosynd-withdrawalstest-frameworkmodule refactor to build fewer binaries. See belowBreaking changes?
Metrics changes?
Anything interesting?
I discovered that
cargohas special behavior for test files in a/testsdirectory. It will compile each test file into a separate binary. With many test files, that compilation overhead + all those artifacts add up. We can get around this via onemain.rstest file which produces one binary for a faster+smaller build.References:
cargomaintainercargoHow can this PR be tested?