Make Flask subdomain matching configurable via SUBDOMAIN_MATCHING
#151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
In PR #142 we bumped Flask (2.3.3→3.1.0) and Werkzeug (3.0.1→3.1.3), which inadvertently disabled Flask’s default subdomain routing behavior. As a result, our blueprints registered with
subdomain="api"
andsubdomain="packages"
no longer matched incoming requests on those hosts, breaking key endpoints in production.What this PR does:
SUBDOMAIN_MATCHING
flag toconfig.py
, defaulting toFalse
for local development.app.py
), readsSUBDOMAIN_MATCHING
and setsapp.subdomain_matching
accordingly.Why this is required:
api.<domain>
andpackages.<domain>
that stopped matching after the Flask/Werkzeug upgrade.localhost
) without subdomains.Usage:
SUBDOMAIN_MATCHING=False
inconfig.py
.SUBDOMAIN_MATCHING=True
(via your production config) to re-enable subdomain‐based routing.Fixes: #144