-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Create proper debug configuration #6193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create proper debug configuration #6193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First off, thnx a lot for your contribution. You actually went quite a bit into the weeds in here, well done. You'll find a a few questions, suggestions & changes proposed part of my review.
for at least spk/ffmpeg To check against https://github.com/icegood/spksrc/tree/fix/libpng_debug_builds at it fixes png bug Applicable for issue SynoCommunity#6176 Signed-off-by: Serhii Ivanov <[email protected]>
5b303d0
to
2e7248b
Compare
- Now enforce cleaning-up the environment to discard any *FLAGS which in turns avoid conflicting with 'build' vs 'host' compiling flags and should avoid generating 'build' targetted compiled tools to end-up being 'host' targetted arch due to env flags. - Generation of the CMake toolchain file is now within its own spksrc.cross-cmake-toolchainfile.mk similar to meson using spksrc.cross-meson-crossfile.mk using the same code layout
@hgy59 Due to a crash with tvheadend I needed to generate a dull Debug build of its entire stack... i recalled the nice work from @icegood that I reused and enhanced and with it I can now generate a fully consistent debug build with proper If you don't mind having a look at this - and testing a few builds that you think may be useful to validate - would be real nice. Thnx. |
@hgy59 i've hit a few corner cases, needs a bit more love before its fully baked. |
Builds looks good, from my perspective this is now ready for merge. |
Description (original from @icegood)
With this PR it is easier to create more rigorous debug builds for further debugging in gdb. (for at least spk/ffmpeg)
Not applicable out of the box since other dependant repos need to be fit as well.
To check against: https://github.com/icegood/spksrc/tree/fix/libpng_debug_builds at it fixes png bug
Applicable for issue #6176
Additions (from @th0ma7)
spksrc.cross-cmake.mk
(similar to meson)CMake
andmeson
(fix issue against 'build' vs 'host' builds)[built-in options]
andfortran_*
instead offc_*
CMAKE_*_FOR_BUILD
to CMake toolchain definitionENV
with autoconf/autotoolsspksrc.copy.mk
would not exit on error using tar from pipeRelates to #6719
Checklist
all-supported
completed successfullyType of change
smallframework changesTests
Tested in debug mode against:
synocli-videodriver
ffmpeg
python312
tvheadend