Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet 8 -> 8.0.12 & 9 -> 9.0.1 #6393

Merged
merged 6 commits into from
Jan 19, 2025

Conversation

brice-fromentin
Copy link
Contributor

Description

Update dotnet 8 -> 8.0.12
Update dotnet 9 -> 9.0.1

Use new URL schemes for runtimes download.

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

Update dotnet 9 -> 9.0.1

Use new URL schemes for runtimes download.
@hgy59 hgy59 added the dotnet Related to dotnet (core) label Jan 15, 2025
@hgy59
Copy link
Contributor

hgy59 commented Jan 15, 2025

@brice-fromentin thanks for this update.
If the download URLs for the arch specific packages differ in the arch part only, you can simplify the definition.

Please take cross/kavita as example:

PKG_DIST_NAME = $(PKG_NAME)-linux-$(PKG_DIST_ARCH).$(PKG_EXT)

...


# use digests with multiple files
PKG_DIST_ARCH_LIST = x64 arm arm64

include ../../mk/spksrc.archs.mk
ifeq ($(findstring $(ARCH),$(x64_ARCHS)),$(ARCH))
PKG_DIST_ARCH = x64
else ifeq ($(findstring $(ARCH),$(ARMv7_ARCHS)),$(ARCH))
PKG_DIST_ARCH = arm
else ifeq ($(findstring $(ARCH),$(ARMv8_ARCHS)),$(ARCH))
PKG_DIST_ARCH = arm64
endif

So you can drop the definitions of PKG_DIST_SITE_LIST (and PKG_DIST_FOLDER).

@brice-fromentin
Copy link
Contributor Author

@hgy59 thx for the feedback, the latest commit is OK.

@mreid-tt
Copy link
Contributor

mreid-tt commented Jan 16, 2025

Hi @brice-fromentin, thank you for submitting these updates! I recall that when you first introduced .NET 9, there was some related testing conducted that might still be relevant. @hgy59 had shared those details earlier, which could be valuable to incorporate into the validation of these updates: #6344 (comment).

Tested on x64 DSM 6.2.4 @ DSM 7.1
@hgy59
Copy link
Contributor

hgy59 commented Jan 17, 2025

@brice-fromentin what was the motivation to use TAR_CMD?

This variable was introduced for developers that use spksrc docker image on mac os, as workaround to extract the downloaded sources.
It was never ment to be used outside of spksrc.extract.mk.
related to #3570

@brice-fromentin
Copy link
Contributor Author

@hgy59 it is an error, I had lots of issues today with the build on docker on macOS so I used $(TAR_CMD). But it breaks the builds so I rollbacked.

@brice-fromentin
Copy link
Contributor Author

@mreid-tt , I completed the tested on DSM 6.2.4 & DSM 7.1 on x64 architecture. I had some issues related to docker on macOS so I will dig a little before the next update of dotnet.

@hgy59
Copy link
Contributor

hgy59 commented Jan 17, 2025

@brice-fromentin can you please add an update of /native/dotnet-sdk-8.0 to 8.0.405?

Since CVE-2025-21173 is related to Linux, we should update the sdk to build jellyfin.

@brice-fromentin
Copy link
Contributor Author

@hgy59 OK, I do it.

@brice-fromentin
Copy link
Contributor Author

@hgy59 @mreid-tt , I update the dotnet 8 sdk, build the Jellyfin package and install it on DSM 7.2 x64.

@hgy59 hgy59 merged commit 5834869 into SynoCommunity:master Jan 19, 2025
15 checks passed
@hgy59 hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet Related to dotnet (core) status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants