Skip to content

Conversation

smaarn
Copy link
Contributor

@smaarn smaarn commented Sep 20, 2025

Description

This is a mere bump of bazarr from 1.5.2 to 1.5.3 and also includes the upgrade of lxml (from 5.4.0 to 6.2.0).

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • [ ] Any needed documentation is updated/created

Type of change

  • Package update

@mreid-tt
Copy link
Contributor

@smaarn, may I suggest moving to lxml==6.0.2 in the requirements-crossenv.txt.

@smaarn
Copy link
Contributor Author

smaarn commented Oct 11, 2025

@smaarn, may I suggest moving to lxml==6.0.2 in the requirements-crossenv.txt.

@mreid-tt will be checking the impact of doing so. Any particular reason for the move ?

@mreid-tt
Copy link
Contributor

@mreid-tt will be checking the impact of doing so. Any particular reason for the move ?

I was just checking this against the standard requirements generator, and that was the only component available for update. I also noticed that this version has already been tested with the wheels package for Python 3.12, so it appears to be build-tested already.

@smaarn
Copy link
Contributor Author

smaarn commented Oct 11, 2025

@mreid-tt will be checking the impact of doing so. Any particular reason for the move ?

I was just checking this against the standard requirements generator, and that was the only component available for update. I also noticed that this version has already been tested with the wheels package for Python 3.12, so it appears to be build-tested already.

Fair enough. My only worry here is the functional impacts which could need being investigated. Building locally to see how it goes.

@smaarn
Copy link
Contributor Author

smaarn commented Oct 11, 2025

Did a little bit of digging and the features which were actually dropped (according to the changelog) are not used in bazarr (direct compressed access or direct access through URLs) so we should be good I guess (ran a few tests and all signals are green...).

@mreid-tt
Copy link
Contributor

Looks good. Don't think it's necessary to include individual package updates in the changelog as this was not the case in previous updates. Otherwise, seems good to go.

@smaarn
Copy link
Contributor Author

smaarn commented Oct 12, 2025

Don't think it's necessary to include individual package updates in the changelog as this was not the case in previous updates.

Too bad we don't have a more advanced "changelog" section allowing to include such details 😅

My main purpose here was to ensure that if some issues are found by users "in the wild" and they check the logs they would be aware of the technical changes which were done and thus may be able to refine their search results and help out potentially... But that's a lot of ifs, I give you that. Will remove.

@smaarn smaarn marked this pull request as ready for review October 12, 2025 09:30
@smaarn smaarn requested a review from mreid-tt October 12, 2025 10:09
@mreid-tt mreid-tt merged commit 2afb8a5 into SynoCommunity:master Oct 12, 2025
15 checks passed
@mreid-tt mreid-tt added status/published Published and activated (may take up to 48h until visible in DSM package manager) and removed status/ready-to-merge labels Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/published Published and activated (may take up to 48h until visible in DSM package manager)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants