-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add native spirv + native DEPENDS fixes #6738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@hgy59 can you generate and publish an updated llvm package online? New version will now provide llvm-spirv which is essential if I later want to include vulkan acceleration. Also, there's a few changes to the framework - I haven't found any regression, it actually solves the dependency management from native which wasn't working, but it could also impact build elsewhere... testing on-going on my end, your help would be appreciated before pushing this one in. |
Got it, but can we update to a newer revision (like v14.0.6 .. v14.0.16)? This would prevent an overwrite of the already prebuilt v14.0.5. |
Nope, at least not yet. I have to stick with the officially supported version(s). I hope to be able to migrate to llvm 15-16+ once I've figured out all the loose ends, but until then no. Also, this really can supplement the existing, or worst, changing the tar method to add a date to it? Yyyy-Qx or similar. |
I could create an xz instead of a tar.gz archive to avoid overwriting existing release. |
@th0ma7 I guess the ninja build path is wrong (in the MSG output only):
|
@th0ma7 another hint (seems to not find the already built SPIRV-Tools) end of
|
@th0ma7 it is built and available as https://github.com/SynoCommunity/spksrc/releases/download/native%2Fllvm/native-llvm-14.0.5.txz but AFAICS it is lacking clang-tblgen, ... |
@th0ma7 BTW the build of native packages still does not create build*.log files. |
@hgy59 your guess is good... and I am able to reproduce locally:
As for the tools: clang-tblgen, llvm-config, llvm-link, llvm-spirv, llvm-tblgen, opt:
I thought I had nailed them all, including
I know, it hurts, I'm so much used to have them everywhere else... Let me add that while this isn't fully backed yet. And thnx for testing (there may be another round later :) |
@hgy59 I think I've addressed all cases from above... logging isn't yet like I want it but the method used is sooooo much simpler than current... I'll work it out a bit more to get to the level I want it to be. Give it a shot and let me know if you'd like a few adjustments or having any ideas... I'll bring those back to cross|spk .. |
@th0ma7 updated version with sha256:22e11a29783e6fcc09343d9d8de724492f547d45be761fe17715e6bc86bb9843 uploaded (same url). |
@mreid-tt and @hgy59 i was able to do a major simplification of our main call-up scripts to always use native|cross-cc.mk which will greatly help maintenance in the future. I still have cross-go to complete, otherwise the remaining would be ready for another round of testing so any remaining issue can be fixed. If you have a moment to shake bugs up on this pr would be much appreciated. |
@th0ma7 didn't you plan to update native/llvm-14.0 with the updated prebuild that includes spriv? |
@hgy59 yes, but as soon i push this in it will initiate long builds... Thus trying to reduce useless builds while i can. |
@th0ma7 Found this issue when building synocli-videodriver:
The github build action would not have an issue with this, so it is mandatory to run tests locally. |
ifndef WORK_DIR | ||
ifndef ARCH_SUFFIX | ||
WORK_DIR := $(CURDIR)/work-native | ||
else | ||
WORK_DIR := $(CURDIR)/work$(ARCH_SUFFIX) | ||
endif | ||
export WORK_DIR | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems the breaking change.
Description
Add native spirv + native DEPENDS fixes
Fixes #
Checklist
all-supported
completed successfullyType of change