Add module-help support for Tcl modules #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "module-help" modulefile command has been introduced in Environment Modules 5.6 to provide a way to define help messages simpler than the traditional ModulesHelp procedure, like achieved on Lua modulefiles with the "help()" function. This commit adds "module-help" support for Tcl modulefiles and make it map to the "help()" Lua function when translated by tcl2lua.tcl. Signed-off-by: Xavier Delaruelle <[email protected]>
|
Thanks very much for this PR. I am impressed that you were able to change tcl2lua.tcl and especially update the rt/tclmodules regression test. Thanks!. This has been merged into the main branch and will be part of the next release of Lmod. |
|
@rtmclay your Lmod Regression Testing Guide is very clear and it was quite straightforward to add new tests after finding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "module-help" modulefile command has been introduced in Environment Modules 5.6 to provide a way to define help messages simpler than the traditional ModulesHelp procedure, like achieved on Lua modulefiles with the "help()" function.
This commit adds "module-help" support for Tcl modulefiles and make it map to the "help()" Lua function when translated by tcl2lua.tcl.