Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially revert "Issue 150: Fix discovered problems and update unit tests.". #152

Conversation

kaladay
Copy link
Contributor

@kaladay kaladay commented Oct 21, 2024

relates to #150

This reverts parts of the commit from 822cb21 involving the mimetype.

Strange problems showed up that are unexpected and did not show up when this branch was deployed and tested.

Failed to determine the content type: (URI=https://api-dev.library.tamu.edu/fcrepo/rest/0a/eb/00/7d/0aeb007d-68bc-4c31-bece-508112e6f9c7/q-and-kevin-saf_objects/3/pages/page_0/files/new%20image%20again.jpg : stream=image/jpeg)

Investigation shows that these problems already existed but the failure was obscured more.
This reverts puts back some of the original Mimetype code (identified during this WIP commit 822cb21).
A new issue will need to be created or an existing issue will need to be updated.

The behavior on production looks like this:

[line: 1, col: 1 ] Out of place: [KEYWORD:����]

See (https://api.library.tamu.edu/iiif-service/fedora/presentation/a6/f0/55/01/a6f05501-9312-4fd5-a167-f7ce2fa28ca6/com_class_rosters_objects/10/pages/page_0/files/COMClass1989.jpg)

The error message on development is improved and looks like:

Failed to determine the content type: (URI=https://api-dev.library.tamu.edu/fcrepo/rest/a6/f0/55/01/a6f05501-9312-4fd5-a167-f7ce2fa28ca6/com_class_rosters_objects/10/pages/page_0/files/COMClass1989.jpg : stream=image/jpeg)

…tests.".

This reverts parts of the commit from 822cb21 involving the mimetype.

Strange problems showed up that are unexpected and did not show up when this branch was deployed and tested.
```
Failed to determine the content type: (URI=https://api-dev.library.tamu.edu/fcrepo/rest/0a/eb/00/7d/0aeb007d-68bc-4c31-bece-508112e6f9c7/q-and-kevin-saf_objects/3/pages/page_0/files/new%20image%20again.jpg : stream=image/jpeg)
```
@kaladay kaladay requested a review from a team October 21, 2024 16:35
@coveralls
Copy link

Coverage Status

coverage: 48.862%. remained the same
when pulling 9d4bbb4 on cantaloupe_sprint_2_staging-revert_problems-2
into ec802b9 on cantaloupe_sprint_2_staging.

@kaladay kaladay merged commit e1456a2 into cantaloupe_sprint_2_staging Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants