Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot fix #214

Merged
merged 4 commits into from
May 15, 2023
Merged

Hot fix #214

merged 4 commits into from
May 15, 2023

Conversation

jeremythuff
Copy link
Member

@jeremythuff jeremythuff commented May 12, 2023 •
edited
Loading

This addresses the email attachment regression by introducing a new regression that causes emails to always attach the file referenced by the attachmentPath.

This additional regression has been recorded with this issue

@jeremythuff jeremythuff requested review from jcreel, a user and rmathew1011 May 12, 2023 18:06
kaladay
kaladay approved these changes May 15, 2023
View reviewed changes
Copy link

@kaladay kaladay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually do not include commented out code, but as this is a hot fix I approve.

@jeremythuff jeremythuff merged commit aab131a into main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladay kaladay kaladay approved these changes

@jcreel jcreel Awaiting requested review from jcreel

@rmathew1011 rmathew1011 Awaiting requested review from rmathew1011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremythuff @kaladay