[Issue #257]: Encrypt passwords in BPMN, decrypt with expression #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires TAMULib/mod-workflow#136
This is incomplete work. However plain text passwords are no longer in BPMN.xml downloadable from Camunda Dashboard and no longer persisting in mod-workflow database.
Plain text passwords are still being exposed in the Camunda Dashboard for RequestTask input variables. All of these just happen to be from fw-registry workflows okapi login, a duplicate node. The asSecure flag added to EmbeddedVariable is to inform the custom Java Delegates implementing Input with getInputs decrypting those that are asSecure while Output implementation of setOutput encrypting those that are asSecure before setting as LOCAL or PROCESS variable.