Fix clicking TAStudio column header with non-contiguous rows selected #4332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a lot of code with logic I don't want to read to fix this niche thing... How about making a |
|
|
Morilli
reviewed
May 26, 2025
YoshiRulz
force-pushed
the
tastudio-toggle-fix
branch
from
b87b346 to
1e8b621
Compare
Morilli
reviewed
May 29, 2025
Comment on lines
+386
to
+392
| while (iSelection < selection.Length) | ||
| { | ||
| var index = selection[iSelection]; | ||
| if (index - lastFrameIndexSeen is not 1) break; | ||
| lastFrameIndexSeen = index; | ||
| iSelection++; | ||
| } |
There was a problem hiding this comment.
I still don't understand why you duplicated this loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and prepare for #1399. I just need to figure out where TAStudio would get called into when buttons are pressed, since that's normally handled via
InputManagerI believe.