Improve development experience #199
Conversation
…d get_channel and get_forum_channel - Fixed c-help-redirect stuff - add option to get_channel and get_forum_channel to optionally also check for channel type
jeremy-rifkin
left a comment
jeremy-rifkin
left a comment
There was a problem hiding this comment.
Hi, thanks for taking the time to contribute to the bot! Some initial comments below
| override async setup(commands: CommandSetBuilder) { | ||
| this.skill_roles = unwrap(this.wheatley.components.get("SkillRoles")) as SkillRoles; | ||
|
|
||
| this.wheatley.validateChannelsAndRoles("channel", categories_map); |
There was a problem hiding this comment.
Something like this shouldn't be called by a random component
There was a problem hiding this comment.
how would you do this instead? adding it into bot-utilities?
| const channel_context = | ||
| message.channel.id === this.wheatley.channels.memes | ||
| ? " in #memes" | ||
| : message.channel.id === this.wheatley.channels.cursed_code | ||
| ? " in #cursed-code" | ||
| : ""; |
There was a problem hiding this comment.
A PR like this is much easier to review if it doesn't change functionality
There was a problem hiding this comment.
this variable was never used so i removed it to clean up "Issues" from Sonar - it doesn't change existing functionality.
| return ( | ||
| thread.parentId != null && | ||
| [this.wheatley.channels.code_review, this.wheatley.channels.showcase].includes(thread.parentId) | ||
| [this.wheatley.channels.code_review, this.wheatley.channels.showcase].some(ch => ch.id === thread.parentId) |
There was a problem hiding this comment.
Minor: Better variable name please
There was a problem hiding this comment.
what would you prefer? channel_info?
|
3 participants
This PR improves the development experience by checking for channel and role names while not being in production mode and resolves them automatically.
(+ more minor improvements to be done (?))