chore(launchpad): reuse ImageBackgroundLogoText on TNS, NFT Launchpad and Launchpad ERC20 #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chpad ERC20, remove unused svg
❌ Deploy Preview for teritori-dapp failed.
|
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
n0izn0iz
approved these changes
Nov 5, 2024
WaDadidou
requested review from
hthieu1110,
n0izn0iz,
omarsy,
Villaquiranm and
MikaelVallenet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factorize code to use one component to show this kind of "banner" on 3 screens, regarding this one: https://app.teritori.com/tns
It's better to keep the image's height IMO.
Let me know if it's ugly, we can keep the old style: https://app.teritori.com/launchpad/apply
So, Mobile Now
Mobile Before (LaunchpadBanner and LaunchpadERC20Banner was like that)
Desktop