-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(feed): Allow to focus Article Editor by clicking the placeholder #1372
Conversation
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, i don't get 100% percent why the placeholder is not a props of the editor/input, but looks fine to me to add a TouchableWithoutFeedback to fix the behavior
Actually, when the user clicks on "Type message here", it does nothing.
It's just a placeholder, so we expect that focuses the editor, and lets the user type.
This weird behavior is due to the fact
placheloder
fromdraft-js
Editor
is adiv
So I added a
TouchableWithoutFeedback
that focuses theEditor
whenonPress