Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feed): Allow to focus Article Editor by clicking the placeholder #1372

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

WaDadidou
Copy link
Collaborator

Actually, when the user clicks on "Type message here", it does nothing.
It's just a placeholder, so we expect that focuses the editor, and lets the user type.

image

This weird behavior is due to the fact placheloder from draft-js Editor is a div
image

So I added a TouchableWithoutFeedback that focuses the Editor when onPress

@WaDadidou WaDadidou added bug Something isn't working Social Feed Everything related to the Social Feed labels Nov 16, 2024
@WaDadidou WaDadidou self-assigned this Nov 16, 2024
Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 77ec3aa
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/6738db0da695630008e27aef
😎 Deploy Preview https://deploy-preview-1372--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for testitori ready!

Name Link
🔨 Latest commit 77ec3aa
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/6738db0dacb7f500081ded6b
😎 Deploy Preview https://deploy-preview-1372--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@MikaelVallenet MikaelVallenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i don't get 100% percent why the placeholder is not a props of the editor/input, but looks fine to me to add a TouchableWithoutFeedback to fix the behavior

@n0izn0iz n0izn0iz added this pull request to the merge queue Nov 16, 2024
Merged via the queue into main with commit 08b05a5 Nov 16, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Social Feed Everything related to the Social Feed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a front issue when creating a new article
3 participants