chore: first replace of legacies boxes #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thomarnauld
force-pushed
the
fix/replace-legacy-boxes
branch
6 times, most recently
from
332cbc5
to
eb45356
Compare
clegirar
force-pushed
the
fix/replace-legacy-boxes
branch
4 times, most recently
from
649b601
to
a0858ca
Compare
Signed-off-by: clegirar <[email protected]>
clegirar
force-pushed
the
fix/replace-legacy-boxes
branch
from
7e6f79b
to
8855108
Compare
Signed-off-by: clegirar <[email protected]>
clegirar
force-pushed
the
fix/replace-legacy-boxes
branch
from
076b73d
to
a491c19
Compare
clegirar
changed the title
n0izn0iz
requested changes
Feb 16, 2024
packages/components/boxes/Box.tsx
Outdated
| @@ -53,6 +53,7 @@ export type BoxStyle = Pick< | |||
| | "top" | |||
| | "bottom" | |||
| | "flex" | |||
| | "zIndex" | |||
There was a problem hiding this comment.
zIndex should be passed to the outer component IMO
…sible style props of Box component Signed-off-by: clegirar <[email protected]>
n0izn0iz
changed the title
n0izn0iz
added a commit
that referenced
this pull request
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created smaller and cleaned PR based on #834