-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove a single wallet #969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adjust positionStyle in DropdownWithListItem (feat/wallet-single-delete)
Add logic to select default wallet when no wallet is selected
omniwired
force-pushed
the
feat/wallet-single-delete
branch
from
February 19, 2024 03:30
7ffe2e4
to
2e4d21c
Compare
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
clegirar
previously approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems good.
n0izn0iz
requested changes
Feb 21, 2024
n0izn0iz
reviewed
Feb 22, 2024
Add useEffect hook to TokenScreen.tsx to handle the scenario where the selected wallet is not available. If there is no selected wallet and there are wallets available, set the selected wallet to the first one. If there are no wallets available, navigate to the "NativeWallet" screen. This change ensures that the TokenScreen component behaves appropriately in these scenarios.
…llet-single-delete # Conflicts: # packages/screens/Mini/Wallet/TokenScreen.tsx
Co-authored-by: n0izn0iz <[email protected]>
…ori-dapp into feat/wallet-single-delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.