Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove a single wallet #969

Merged
merged 9 commits into from
Feb 23, 2024
Merged

feat: remove a single wallet #969

merged 9 commits into from
Feb 23, 2024

Conversation

omniwired
Copy link
Collaborator

@omniwired omniwired commented Feb 16, 2024

No description provided.

Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for testitori ready!

Name Link
🔨 Latest commit ae9a7da
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/65d8aae220863d0008023006
😎 Deploy Preview https://deploy-preview-969--testitori.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@omniwired omniwired self-assigned this Feb 16, 2024
Base automatically changed from feat/wallet-account-rename to main February 18, 2024 01:12
adjust positionStyle in DropdownWithListItem (feat/wallet-single-delete)
Add logic to select default wallet when no wallet is selected
Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit ae9a7da
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/65d8aae284952e0008a8888a
😎 Deploy Preview https://deploy-preview-969--teritori-dapp.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

clegirar
clegirar previously approved these changes Feb 19, 2024
Copy link
Collaborator

@clegirar clegirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good.

Add useEffect hook to TokenScreen.tsx to handle the scenario where the
selected wallet is not available. If there is no selected wallet and
there are wallets available, set the selected wallet to the first one.
If there are no wallets available, navigate to the "NativeWallet"
screen. This change ensures that the TokenScreen component behaves
appropriately in these scenarios.
…llet-single-delete

# Conflicts:
#	packages/screens/Mini/Wallet/TokenScreen.tsx
@n0izn0iz n0izn0iz merged commit 9411211 into main Feb 23, 2024
19 checks passed
@n0izn0iz n0izn0iz deleted the feat/wallet-single-delete branch February 23, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants