feat: rework toasts api and add mini mode support in toasts #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
… required for it and, created ToastProvider component
…st context provider
sachin-into
force-pushed
the
feat/mini-Toast
branch
from
39ad2b7
to
b52efdd
Compare
n0izn0iz
requested changes
Feb 22, 2024
n0izn0iz
changed the title
n0izn0iz
requested changes
Feb 23, 2024
Comment on lines
56
to
57
| miniToast: { message: "" }, | ||
| setMiniToast: () => {}, |
There was a problem hiding this comment.
don't add new api, use previous api or extend it and change the toast render only
we need all existing toasts to work in mini mode also
There was a problem hiding this comment.
mini toast has 4 different status and 2 different variant style so I created new api without touching previous working apis. Previous toast works as it used to and new api is for mini mode. Won't that be simple and easier to distinguish?
There was a problem hiding this comment.
I don't think, a toast should be a toast, the mode can affect how it renders but we should have a single api
you can extend the current api
removed: ErrorToast and SuccesToast to make single NormalToast, deprecated use of setToastError and setToastSuccess
…i-dapp into feat/mini-Toast
n0izn0iz
requested changes
Feb 28, 2024
| topOffset?: number; | ||
| } | ||
|
|
||
| export const NormalToast: React.FC<NormalToastProps> = ({ |
There was a problem hiding this comment.
there is a regression in this component, on main it has an icon
on this pr the ! icon does not appear
… required for it and, created ToastProvider component
…st context provider
removed: ErrorToast and SuccesToast to make single NormalToast, deprecated use of setToastError and setToastSuccess
sakul-budhathoki
force-pushed
the
feat/mini-Toast
branch
from
080813d
to
52da131
Compare
n0izn0iz
requested changes
Feb 29, 2024
n0izn0iz
changed the title
clegirar
pushed a commit
that referenced
this pull request
Mar 20, 2024
* feat:created toast component for mini mode and added icons and colors required for it and, created ToastProvider component * refactor: moved toast message clear logic from toast component to toast context provider * refactor: replaced MiniToast on mini comment input * refactor: removed ToastProvider and moved added miniToast on feedback provider * chore: removed console.log * feat: added clear toast on press * refactor: Feedback Provider to use single api for mini and normal toast, removed: ErrorToast and SuccesToast to make single NormalToast, deprecated use of setToastError and setToastSuccess * fix: tsc errors * fix: unused exports error * feat:created toast component for mini mode and added icons and colors required for it and, created ToastProvider component * refactor: moved toast message clear logic from toast component to toast context provider * refactor: replaced MiniToast on mini comment input * refactor: removed ToastProvider and moved added miniToast on feedback provider * chore: removed console.log * feat: added clear toast on press * refactor: Feedback Provider to use single api for mini and normal toast, removed: ErrorToast and SuccesToast to make single NormalToast, deprecated use of setToastError and setToastSuccess * fix: tsc errors * fix: unused exports error * fix: regression * fix: regression no right padding * fix:padding diffrenece in success and error * fix: different with for success and error as in main --------- Co-authored-by: Sakul Budhathoki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.