PCP-12648: README changes #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a prerequisite step for granting Security Context Constraints (SCC) permissions to Data Plane service accounts before deploying on ARO.
- Inserts a new section and table of contents entry about SCC permissions for Data Plane namespaces
- Provides
oc adm policycommands to grant the custom SCC to both the specified service account and the default account
Comments suppressed due to low confidence (2)
docs/workshop/aro (Azure Red Hat OpenShift)/data-plane/README.md:158
- [nitpick] Add a period at the end of this sentence to match the punctuation style of other section descriptions.
Before creating the Data Plane, ensure that the service accounts in the Data Plane namespace have been granted permission to use the Security Context Constraints (SCC) defined in the [cluster setup README](../cluster-setup/README.md#create-security-context-constraints)
docs/workshop/aro (Azure Red Hat OpenShift)/data-plane/README.md:163
- [nitpick] Consider replacing the generic placeholder
nswith an example (e.g.,my-data-plane-namespace) to make the instructions more illustrative.
export DP_NAMESPACE="ns" # Replace with your Data Plane namespace
sasahoo-tibco
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pre-requisite to grant the service account to use SCC