-
Notifications
You must be signed in to change notification settings - Fork 13
Draft: Space point display update -- 3dTo2d projection to Hit Association #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…nks the space point hits across tpc views allowing for shared hover actions (color change + tool tip)
|
Thanks very much @Jjm321814 for your work on this! Looks very nice. My only comment is that this is effectively drawing hits, not spacepoints anymore. I'm afraid this can be a bit confusing, if the spacepoint reconstruction is not perfoerming well, there is no way to tell here because this is PR is bypassing the actual spacepoints and looking at the associated hits. I am wondering if we should make this optional? |
…e or my new addition being wrong
|
Just repinging that this is updated to be compatible with LArSoft V10, and there are two complimentary space point displays for both hits and the 3d space point itself. |
Changes to DrawSpacePoint.cxx, DrawSpacePoint.h and spacepoint.py to prioritize use of space-point hit association object over space-points directly.
Main feature highlights are shown https://docs.google.com/presentation/d/13ozNkPdjZ_9fTyeltv52PiUiTGmpKgSa7UZUs5rXi50/edit#slide=id.p
Space points direct code is removed, so we would need to guarantee that the association plot is always made.
Additionally the _dataByPlane array is filled by a custom HitFromSpacePoint object, rather than a shared object like larutil::Point2D, which may limit the generalizability of code to other systems.
Occasional bugs have been observed with the shared highlighting feature that are fixed by left-clicking to adjust the view slightly.
Note the spacePoint ID displayed in the tool tip is just an index in the vector rather than a value saved to the spacePoint itself.