Skip to content

Conversation

@Jjm321814
Copy link
Collaborator

Changes to DrawSpacePoint.cxx, DrawSpacePoint.h and spacepoint.py to prioritize use of space-point hit association object over space-points directly.

Main feature highlights are shown https://docs.google.com/presentation/d/13ozNkPdjZ_9fTyeltv52PiUiTGmpKgSa7UZUs5rXi50/edit#slide=id.p

Space points direct code is removed, so we would need to guarantee that the association plot is always made.
Additionally the _dataByPlane array is filled by a custom HitFromSpacePoint object, rather than a shared object like larutil::Point2D, which may limit the generalizability of code to other systems.

Occasional bugs have been observed with the shared highlighting feature that are fixed by left-clicking to adjust the view slightly.

Note the spacePoint ID displayed in the tool tip is just an index in the vector rather than a value saved to the spacePoint itself.

@Jjm321814 Jjm321814 self-assigned this Feb 21, 2025
@marcodeltutto
Copy link
Collaborator

Thanks very much @Jjm321814 for your work on this! Looks very nice. My only comment is that this is effectively drawing hits, not spacepoints anymore. I'm afraid this can be a bit confusing, if the spacepoint reconstruction is not perfoerming well, there is no way to tell here because this is PR is bypassing the actual spacepoints and looking at the associated hits.

I am wondering if we should make this optional?

@Jjm321814
Copy link
Collaborator Author

Just repinging that this is updated to be compatible with LArSoft V10, and there are two complimentary space point displays for both hits and the 3d space point itself.

@Jjm321814 Jjm321814 changed the title Space point display update -- 3dTo2d projection to Hit Association Draft: Space point display update -- 3dTo2d projection to Hit Association Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants