Enable param info workflow #65
Conversation
julianbollig
force-pushed
the
enableParamInfoWorkflow
branch
2 times, most recently
from
17af8fc to
dff6c53
Compare
| } | ||
| imageGeneration.processing = false | ||
| imageGeneration.stopping = false | ||
| } | ||
| } | ||
|
|
||
| function createInfoParamTable(infoParams: ImageInfoParams) { | ||
| const mappingKeyToTranslatable: StringKV = { |
There was a problem hiding this comment.
No need for this to be in the function
There was a problem hiding this comment.
Also, the mapping to translation keys is display logic and should probably reside in the component that displays this.
There was a problem hiding this comment.
For reusage of infoTable, I wanted to keep it clean from backend specific mappings. Also, how it is now, the information stored in the generated images is less and cleaner. Further, in case we want at some point to restore images or recreate the settings using the information on the table, it might be easier, if it is more structured from the start.
| lora: infoParams.lora, | ||
| safe_check: infoParams.safe_check, | ||
| } | ||
| return Object.fromEntries( |
There was a problem hiding this comment.
If these two objects should map to each other, this should be reflected in the type.
There was a problem hiding this comment.
I am not sure what you mean by that, can you elaborate further?
|
The way the image preview is designed now, it always jumps to the last image whenever the number of generated images changes. If you delete an image, that might not be, what you want. Shall we leave it that way or account for this special case? |
…Diffusion Signed-off-by: julianbollig <[email protected]>
…bjects rather than just urls Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
…allow for infoParam in ComfyUi Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
julianbollig
force-pushed
the
enableParamInfoWorkflow
branch
from
0bb3050 to
6c5a77a
Compare
Signed-off-by: julianbollig <[email protected]>
Refs: #58 Signed-off-by: Markus Schuettler <[email protected]>
Signed-off-by: Markus Schuettler <[email protected]>
Description:
Please provide a brief description of the changes made in this pull request.
Related Issue:
If this pull request is related to any existing issue, please mention the issue number here.
Changes Made:
Please list down the specific changes made in this pull request.
Testing Done:
Please describe the testing that has been done to ensure the changes made in this pull request are functioning as expected.
Screenshots:
If applicable, please provide screenshots or GIFs or videos to visually demonstrate the changes made.
Checklist: