support dependOnClassesThat() for methods #1135
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: TNG#1060 Signed-off-by: Leonard Husmann <[email protected]>
leonardhusmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following new methods to the public API to check if methods depend on a certain class (matched by
predicate):dependOnArgumentsThat(DescribedPredicate<? super JavaClass> predicate)dependOnReturnTypesThat(DescribedPredicate<? super JavaClass> predicate)accessClassesThat(DescribedPredicate<? super JavaClass> predicate)dependOnClassesThat(DescribedPredicate<? super JavaClass> predicate)The first three methods check for violations of 1) arguments 2) return types and 3) class access referencing
BadClass. The last rule (dependOnClassesThat()) checks for any violation of the first three rules (somehow a convenience function if none of the fine granular access is desired)What do you think? Any feedback is highly appreciated :)
Resolves: #1060