Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fail test run with enabled junit.testFilter option #1361

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    7e3c820 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. fixup! fix fail test run with enabled junit.testFilter option

    Review: I think this is a safer way to do it. In the end, the error says "can't remove the root of a hierarchy", so it makes sense to exactly guard against this, and also it then only uses the general JUnit Platform API and doesn't rely on ArchUnit specifics (and `AbstractArchUnitTestDescriptor` is more an implementation detail, it's more by accident that the rule descriptors, etc., inherit from this, but the engine descriptor doesn't).
    codecholeric committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    d42985a View commit details
    Browse the repository at this point in the history