Conversation
Signed-off-by: Hendrik Vennekate <[email protected]>
generator module Signed-off-by: Hendrik Vennekate <[email protected]>
generator Signed-off-by: Hendrik Vennekate <[email protected]>
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| public class ReportConfigArgumentTest { |
There was a problem hiding this comment.
This is the former ReportGeneratorArgumentTest (next file; deleted). Like the test further down after that, it does not really require the asciidoc reporter, so I replaced it with anonymous classes. It might be worthwhile extracting those or moving/renaming the tests to signify that they are really testing the AbstractReportConfig and AbstractReportGenerator, respectively.
Signed-off-by: Hendrik Vennekate <[email protected]>
|
Hey @hvennekate I've now created a pull request draft #1945 for my old changes after i've integrated the current changes from Let me know if I need to do more adjustments after this PR is merged. |
There was a problem hiding this comment.
Pull Request Overview
This PR extracts the AsciiDoc report generator into its own submodule, structures its build, and adds minimal documentation.
- Replaces explicit local types with
varand removes now-unused imports inAsciiDocReportGenerator.java. - Introduces a new
build.gradlefor the AsciiDoc report submodule with its dependencies. - Adds a basic
README.mdfor the AsciiDoc Report module.
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| jgiven-asciidoc-report/src/main/java/com/tngtech/jgiven/report/asciidoc/AsciiDocReportGenerator.java | Simplified locals with var, removed unused imports |
| jgiven-asciidoc-report/build.gradle | Added java-library plugin and module dependencies |
| jgiven-asciidoc-report/README.md | Created initial AsciiDoc report README |
Comments suppressed due to low confidence (2)
jgiven-asciidoc-report/src/main/java/com/tngtech/jgiven/report/asciidoc/AsciiDocReportGenerator.java:99
- Key methods in
AsciiDocReportGenerator(e.g.writeFeatureFiles,writeIndexFileForFullReport) aren't covered by any unit or integration tests. Consider adding tests that verify generated AsciiDoc blocks and file outputs.
completeReportModel.getAllReportModels().stream()
jgiven-asciidoc-report/README.md:3
- The README is minimal—adding sections for setup, build instructions, usage examples, and links to sample output would help new users get started quickly.
For text-based report output
jgiven-core/src/test/java/com/tngtech/jgiven/report/ReportGeneratorTest.java
Outdated
Show resolved
Hide resolved
jgiven-core/src/test/java/com/tngtech/jgiven/report/ReportGeneratorTest.java
Outdated
Show resolved
Hide resolved
Hi @johthor , |
Signed-off-by: Hendrik Vennekate <[email protected]>
hvennekate
force-pushed
the
iss54/extract_asciidoc_reporter
branch
from
d052819 to
3a17934
Compare
jgiven-core/src/main/java/com/tngtech/jgiven/report/ReportGenerator.java
Outdated
Show resolved
Hide resolved
jgiven-core/src/main/java/com/tngtech/jgiven/report/ReportGenerator.java
Outdated
Show resolved
Hide resolved
jgiven-core/src/main/java/com/tngtech/jgiven/report/ReportGenerator.java
Outdated
Show resolved
Hide resolved
jgiven-core/src/main/java/com/tngtech/jgiven/report/ReportGenerator.java
Outdated
Show resolved
Hide resolved
...gradle-plugin/src/main/java/com/tngtech/jgiven/gradle/internal/AbstractJGivenReportImpl.java
Outdated
Show resolved
Hide resolved
jgiven-maven-plugin/src/main/java/com/tngtech/jgiven/maven/JGivenReportMojo.java
Outdated
Show resolved
Hide resolved
hvennekate
force-pushed
the
iss54/extract_asciidoc_reporter
branch
2 times, most recently
from
19c3849 to
3a17934
Compare
Signed-off-by: Hendrik Vennekate <[email protected]>
…port generator Signed-off-by: Hendrik Vennekate <[email protected]>
Signed-off-by: Hendrik Vennekate <[email protected]>
hvennekate
force-pushed
the
iss54/extract_asciidoc_reporter
branch
from
66f8fae to
31774b0
Compare
Signed-off-by: Hendrik Vennekate <[email protected]>
Signed-off-by: Hendrik Vennekate <[email protected]>
|
|
||
| switch (parsedFormat) { | ||
| case ASCIIDOC: | ||
| var generator = switch (parsedFormat) { |
There was a problem hiding this comment.
Nice!
Is that java17 conformant?
No description provided.