Mongo errors 624 #627
Merged
Mongo errors 624 #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove unused method in MongoSchedule Signed-off-by: Ute Weiss <[email protected]>
Signed-off-by: Yani Kolev <[email protected]>
…hout spamming mongo errors * clean up SchedulesRepository methods to not take scheduleName or scheduleId as parameters (these are known in repo anyway) * introduce ScheduleState for clean implementation of the fact whether this instance, another instance or no instance is active for a schedule Signed-off-by: Yani Kolev <[email protected]> Signed-off-by: Ute Weiss <[email protected]>
… fix enum for consistency Signed-off-by: Ute Weiss <[email protected]>
Signed-off-by: Ute Weiss <[email protected]>
# Conflicts: # src/repository/SchedulesRepository.ts
YaniKolev
approved these changes
Oct 6, 2023
Signed-off-by: Ute Weiss <[email protected]>
Signed-off-by: Ute Weiss <[email protected]>
Signed-off-by: Ute Weiss <[email protected]>
YaniKolev
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #624