Fixed ghost viewmodels briefly appearing from weapons held by other players #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimGoll
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, random pieces of viewmodels (arms, floating guns) would appear briefly during rounds. Today, I noticed I was able to reliably trigger the bug by making a mimic bot use ironsights while looking towards the center of the map.
I couldn't find exactly what the root cause was, but I did find it was the LocalPlayer's viewmodel entity briefly rendering another weapon...
This PR patches out the issue. Spectating players in first-person still works fine.
Demo of the bug (I'm spamming right-click to make the bot use ironsights):
https://github.com/user-attachments/assets/49c7dfa0-4823-47f5-95be-4858198b9e7d