Skip to content

VoiceChat: Added option for team proximity voicechat #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

NickCloudAT
Copy link
Contributor

This adds a new convar/menu option to enable/disable proximity voice chat for the team voice chat.

This tackles #1810

I was NOT yet able to test this! For me it seems 100% fine but if anyone can/wants to test it before merging, please do so.

@NickCloudAT
Copy link
Contributor Author

image
Also.. As one check here complainted about the unused variable.. Should I put the new setting below all other settings?
All settings below have the main voice chat setting as master, so I guess I should move that down?

@TimGoll
Copy link
Member

TimGoll commented May 23, 2025

Two things:

  • by default the team voice chat should not be locational (I think you already did it that way)
  • the way you put it in the UI is wrong, team voice chat is not the master setting here I think? Because the other settings are related to everything proximity related

@NickCloudAT
Copy link
Contributor Author

NickCloudAT commented May 23, 2025

Two things:

  • by default the team voice chat should not be locational (I think you already did it that way)
  • the way you put it in the UI is wrong, team voice chat is not the master setting here I think? Because the other settings are related to everything proximity related

Default is not locational, yes.
Yes, right now it's 100% wrong in the UI. That's why I wondered.. Should I just move the new option down? Or should the new option also depend on the main location voice setting?

@TimGoll
Copy link
Member

TimGoll commented May 23, 2025

If proximity voice chat is disabled (the first setting), then team proximity is disabled as well (no matter the setting 2) - is this correct?

If so, I'd just move it down somewhere, so it is in the indented layer, but not at the top. I'd just move it below the slider

@NickCloudAT
Copy link
Contributor Author

If proximity voice chat is disabled (the first setting), then team proximity is disabled as well (no matter the setting 2) - is this correct?

If so, I'd just move it down somewhere, so it is in the indented layer, but not at the top. I'd just move it below the slider

Well, no. If I'm not mistaken and can read the code correctly, the two values are separated. If I disable normal prox chat, the team prox chat should still work if enabled.
But well, after thinking about it, maybe it would be better to make it only work if the default prox voice chat is enabled too?

@TimGoll
Copy link
Member

TimGoll commented May 24, 2025

But well, after thinking about it, maybe it would be better to make it only work if the default prox voice chat is enabled too?

Yes, I agree with that! :)

@NickCloudAT
Copy link
Contributor Author

But well, after thinking about it, maybe it would be better to make it only work if the default prox voice chat is enabled too?

Yes, I agree with that! :)

I guess that should be it then.

This is how it would be now:
image

@NickCloudAT
Copy link
Contributor Author

Just asking; Anything else I should do here?

@saibotk saibotk requested a review from TimGoll June 12, 2025 16:49
Copy link
Member

@TimGoll TimGoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, that was it. I just forgot about it! Thanks a lot as always :)

@TimGoll TimGoll merged commit 7ee2866 into TTT-2:master Jun 12, 2025
4 checks passed
@mexikoedi
Copy link
Contributor

I noticed that this change wasn't mentioned in the changelog of v0.14.4b.
It seems it was misplaced and is now listed under v0.14.3b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants