-
Notifications
You must be signed in to change notification settings - Fork 87
VoiceChat: Added option for team proximity voicechat #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Two things:
|
Default is not locational, yes. |
If proximity voice chat is disabled (the first setting), then team proximity is disabled as well (no matter the setting 2) - is this correct? If so, I'd just move it down somewhere, so it is in the indented layer, but not at the top. I'd just move it below the slider |
Well, no. If I'm not mistaken and can read the code correctly, the two values are separated. If I disable normal prox chat, the team prox chat should still work if enabled. |
Yes, I agree with that! :) |
Just asking; Anything else I should do here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, that was it. I just forgot about it! Thanks a lot as always :)
I noticed that this change wasn't mentioned in the changelog of v0.14.4b. |
This adds a new convar/menu option to enable/disable proximity voice chat for the team voice chat.
This tackles #1810
I was NOT yet able to test this! For me it seems 100% fine but if anyone can/wants to test it before merging, please do so.