Fixed not being able to use entities through water and clip brushes #1826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saibotk
approved these changes
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, trying to use entities and pick up weapons through water and clip brushes doesn't work, even though your TargetId HUD says you can.
This was happening because the clientside trace was using MASK_ALL. I've now changed to MASK_SOLID + CONTENTS_DEBRIS, which is roughly the same mask that the TargetId HUD uses.
I'm aware #1821 exists which I assume would fix this problem when it's eventually merged in, but I thought I would patch this issue specifially while that PR is still in the works.