[Feature] Coordinate sainity check

[CommanderStorm]

Is your feature request related to a problem? Please describe.
as noticed in #129, some oviously wrong coordinates (for example https://nav.tum.de/room/0104.U1.421) exist.
Ideally, we should notice (and then fix) these coordinates before we see them in production.

Describe the solution you'd like
I would like to have a coordinate check. This could be implemented via a coverage approach (max(lat)-min(lat))*(max(lon)-min(lon)) or via an absolute distance approach.
The distance thresholds could be hardcoded or infered from the 95'th percentile of buildings in the same category

Describe alternatives you've considered
Not implementing such a check and waiting for user feedback, that indeed their shower is not located in africa..

Additional context
These cases seem to be really rare.
There are most likely only a single digit amount of rooms, that are affected.

[XSpielinbox]

Room 0104.U1.421 still has these useless coordinates.

[CommanderStorm]

Yes, never got to that , but since this is now warned in CI (and the room frankly is not important to walk there with priority)
=> Not reopening. It is only one room, all others are fine by all methods tried

Maybe I will get to it sometime.. if you know the coordinates that would be appreciated ^^

[XSpielinbox]

What is the best way to retrieve these coordinates, because GPS on my mobile phone is really bad inside buildings even with assisted GPS turned on an using "precise location"?

Eye balling it from the outside of the building I would say the coordinates are something near 48.15093/11.56864, but even showing the coordinates of the building and then the message "Die angezeigte Position zeigt nur die Position des Gebäude(teils). Die genaue Lage innerhalb des Gebäudes ist uns nicht bekannt." would be much more helpful than this definitely wrong location.

Given the interactive map ("Interaktive Karte") or "Lageplan" from other rooms in that floor I know where on these maps it should be. How can I add a location to one of these maps in a good way?

[CommanderStorm]

What is the best way to retrieve these coordinates

Currently, that is not great, I know. I usually just estimate the coordinates.
GPS is useless indorrs, maybe we can deploy Beacons but that is future-music.

I hope that getting the data-deal with tum which #1325 is buildign on can improve this quite a lot.

Given the interactive map ("Interaktive Karte") or "Lageplan" from other rooms in that floor I know where on these maps it should be.
How can I add a location to one of these maps in a good way?

If you mean editing the actual maps, these maps are locaed

• here for the raw, scraped legacy-roomfinder maps,
• here for the maps that we have drawn/modified and here for the maps which have sources avaliable

Coordinate overrides are locaed here, the base data here comes from the legacy mytum roomfinder, hopefully this can be moved to CAD-Data and manual patches via #1325.

[XSpielinbox]

I seem to have set the coordinates slightly wrong, but this is difficult to do blindly for a room that is probably 4.09m². Can I somehow change this iteratively and see where it comes out in the interactive map in order to find the correct point?

Is there anything I can help with with the data deal you mentioned?

I will try to look at the maps whether I can infer, how I can edit them to make a PR for corrected ones. If you have any additional instructions/help in that regard, that would be greatly appreciated.

[XSpielinbox]

No, with the last one I mean https://github.com/TUM-Dev/NavigaTUM/tree/main/data/external/results/maps/roomfinder

(Yes, this is a mess => moging to CAD fixes this hopefully.. lets see)

Hm, this link you already put behind the first "here", where it makes sense, but it does not make sense for the last "here".

[XSpielinbox]

I have just marked the room in a manually adjusted floor plan with a red square, to make it more clear, which room we are talking about and where it should be:

[CommanderStorm]

Hm, this link you already put behind the first "here", where it makes sense, but it does not make sense for the last "here".

True, did not read correctly. I meant this file

[XSpielinbox]

@CommanderStorm
Thanks for the Information on how to retrieve the coordinates.
The information for room N-1421 should therefore probably be: "0104.U1.421": { lat: 48.15089929865698, lon: 11.568621333837228 }

Also I noticed, that https://raw.githubusercontent.com/TUM-Dev/NavigaTUM/main/data/external/results/rooms_roomfinder.json does list default maps and for e.g. for the N-1421 this is the "Stammgelände Basiskarte" and the only one one can select.
For e.g. the N-1403 is lists there all maps one can select and all maps have the right points shown for the N-1403.
Whereas for all rooms where I have informed you in the respective issues that the default maps are wrong there is no room entry in this file and for these rooms one can select all possible maps, including numerous which don't make sense at all, because the marker will never be correct on the map of a different building.
Is there a possibility to override these entries? It looks to me like this is causing the issues.

[CommanderStorm]

Yes, mytum used to under-select building plans a lot. We trew this into the dumpster pretty quickly, as that not reporting maps if you have them is not great.
=> we therefore try to be smart about assignment, but likely a bug has slipped in here.

While overriding is possible, this bug is not the only time it has been reported:

• Inconsistent map position between the lageplan and dynamic map #512
• [4214.EG.030]: interaktive karte und lageplan stimmen nicht überein #1328

Read:
The site-plan assigning issue needs to either be fixed at the source, or resolved by replacing the plans alltogether.
Replacing the alltogether is something that I would like to do via

• Add server-side raster tile rendering maplibre/martin#978
• and its depencencys

[XSpielinbox]

@CommanderStorm Thanks for correcting the coordinates. Now it is correct!