Skip to content

CleanUp AuthenticationService #5762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Conversation

froemken
Copy link
Contributor

Before patching #5745 I prefer to cleanup that part in docs first.

@linawolf linawolf self-assigned this Jun 20, 2025
@linawolf linawolf added backport 12.4 Backport to TYPO3v12 backport 13.4 Backport to TYPO3v13 labels Jun 20, 2025
@linawolf linawolf merged commit 38f2518 into main Jun 20, 2025
12 checks passed
@linawolf linawolf deleted the sfCleanUpAuthenticationService branch June 20, 2025 06:56
Copy link
Contributor

The backport to 12.4 failed:

The process '/usr/bin/git' failed with exit code 1
stderr
error: could not apply 6c433f3aa... CleanUp AuthenticationService
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

stdout
CONFLICT (modify/delete): Documentation/ApiOverview/Authentication/AuthenticationService/Index.rst deleted in HEAD and modified in 6c433f3aa (CleanUp AuthenticationService).  Version 6c433f3aa (CleanUp AuthenticationService) of Documentation/ApiOverview/Authentication/AuthenticationService/Index.rst left in tree.

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-12.4 12.4
# Navigate to the new working tree
cd .worktrees/backport-12.4
# Create a new branch
git switch --create backport-5762-to-12.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 6c433f3aae2849529004bda812711121ff74d5df
# Push it to GitHub
git push --set-upstream origin backport-5762-to-12.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-12.4

Then, create a pull request where the base branch is 12.4 and the compare/head branch is backport-5762-to-12.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport failed backport 12.4 Backport to TYPO3v12 backport 13.4 Backport to TYPO3v13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants